[fix](variant) fix variant column data_serdes not synced #60908
Merged
eldenmoon merged 1 commit intoapache:masterfrom Mar 5, 2026
Merged
[fix](variant) fix variant column data_serdes not synced #60908eldenmoon merged 1 commit intoapache:masterfrom
eldenmoon merged 1 commit intoapache:masterfrom
Conversation
…array_nullable and ensure_root_node_type When `wrapp_array_nullable()` wraps a ColumnArray with ColumnNullable, it updates `data_types[0]` but not `data_serdes[0]`, leaving a stale serde. Similarly, `ensure_root_node_type()` casts the root column (e.g. INT32 -> JSONB) and updates `data[0]` and `data_types[0]`, but not `data_serdes[0]`. This causes BE crash during MV refresh with row store enabled: when `serialize_text_json()` uses the stale `data_serdes[0]` (e.g. INT32 serde) on the actual column data (e.g. JSONB ColumnString), `assert_cast` fails. Fix: sync `data_serdes[0]` in both `wrapp_array_nullable()` and `ensure_root_node_type()` after updating `data_types[0]`.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 28883 ms |
TPC-DS: Total hot run time: 184167 ms |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Member
|
skip check_coverage |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
airborne12
approved these changes
Mar 5, 2026
Member
airborne12
left a comment
airborne12
left a comment
There was a problem hiding this comment.
LGTM ✅
Reviewed both fixes:
wrapp_array_nullable(): syncdata_serdes[0]aftermake_nullable(data_types[0])ensure_root_node_type(): syncdata_serdes[0]after root type cast
Verified all 8 data_types[] write sites — these 2 were the only ones missing data_serdes sync. Regression test covers both trigger paths.
csun5285
added a commit
to csun5285/doris
that referenced
this pull request
Mar 6, 2026
yiguolei
pushed a commit
that referenced
this pull request
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)